Skip to content

Fix Incoming Documents default processed filter - #9401

Merged
Jesper Schulz-Wedde (JesperSchulz) merged 4 commits into
mainfrom
jesperschulz-fix-incoming-documents-filter
Aug 17, 2026
Merged

Fix Incoming Documents default processed filter#9401
Jesper Schulz-Wedde (JesperSchulz) merged 4 commits into
mainfrom
jesperschulz-fix-incoming-documents-filter

Conversation

@JesperSchulz

@JesperSchulz Jesper Schulz-Wedde (JesperSchulz) commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

What & why

Incoming Documents no longer defaulted to unprocessed records when opened without a filter, and an explicit Processed = true filter could be cleared. Restore the default Processed = false view while preserving explicitly supplied true and false filters.

Regression tests cover all three filter scenarios.

Linked work

Fixes AB#637747

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required - be specific: scenarios, commands, screenshots for UI changes)

  • Added regression coverage verifying that an unfiltered page defaults to unprocessed documents.
  • Added regression coverage verifying that explicit Processed = true and Processed = false filters are preserved.
  • Local execution was not completed because this workspace has no Business Central container or required AL package cache.

Risk & compatibility

Low risk. The change only affects initial page filter handling and retains existing Show All/Show Unprocessed action behavior. No data, permissions, or upgrade impact.

Restore the default unprocessed view while preserving explicit processed filters and add regression coverage for each filter scenario.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a22e32be-3141-40ed-9a78-2302b3ba294f
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 14, 2026
@JesperSchulz Jesper Schulz-Wedde (JesperSchulz) added the Team: Integrations GitHub request for Integrations area label Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 4 · Outcome: completed

All 16 sub-skills ran to completion (either 'completed' or 'not-applicable'); none produced findings against the small, well-tested filter-preservation fix in IncomingDocuments.Page.al and its accompanying test additions.

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the Copilot CLI agent against BCQuality at 186d8a131465475c79244d994acb872cd5c0d4bf. Reply 👎 on any inline comment to flag false positives.

Comment thread src/Layers/W1/BaseApp/eServices/EDocument/IncomingDocuments.Page.al Outdated
Address review feedback by using the existing helper for the default unprocessed view.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a22e32be-3141-40ed-9a78-2302b3ba294f
Comment thread src/Layers/W1/BaseApp/eServices/EDocument/IncomingDocuments.Page.al Outdated
Only apply the default unprocessed filter when no Processed filter is supplied, preserving the intent of bug 609129. Cover the action state for filtered entry points.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a22e32be-3141-40ed-9a78-2302b3ba294f
Comment thread src/Layers/W1/Tests/ERM/ERMIncomingDocuments.Codeunit.al
Clear and verify variable storage around the modal page handler so each filter scenario proves the expected interaction.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a22e32be-3141-40ed-9a78-2302b3ba294f
@JesperSchulz

Copy link
Copy Markdown
Contributor Author

Re-running CI. Something is off with the one last task which keeps failing.

Comment thread src/Layers/W1/BaseApp/eServices/EDocument/IncomingDocuments.Page.al
Comment thread src/Layers/W1/Tests/ERM/ERMIncomingDocuments.Codeunit.al
Comment thread src/Layers/W1/Tests/ERM/ERMIncomingDocuments.Codeunit.al
Merged via the queue into main with commit 042757f Aug 17, 2026
1109 of 1149 checks passed
@JesperSchulz
Jesper Schulz-Wedde (JesperSchulz) deleted the jesperschulz-fix-incoming-documents-filter branch August 17, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: Integrations GitHub request for Integrations area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants